NOJIRA example of propagating service nav usage#367
Draft
oscarduignan wants to merge 1 commit intomainfrom
Draft
NOJIRA example of propagating service nav usage#367oscarduignan wants to merge 1 commit intomainfrom
oscarduignan wants to merge 1 commit intomainfrom
Conversation
This was referenced Feb 19, 2026
oscarduignan
force-pushed
the
NOJIRA-example-of-propagating-service-nav-usage
branch
from
2194947 to
783f181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example of service being able to override how service nav usage gets determined - for example by matching against some identifier from the request to a list from config
where service nav feature flag has been turned in the play-frontend-hmrc snapshot into a trait so that it can be overridden
hmrc/play-frontend-hmrc#397
hmrc/help-frontend#172
if people needed to base decision off something else, then instead they could use the one that bases decision off present of request attribute, and then they "just" need to add that request attribute in during the chain
for example, if someone was looking up say user answers or address lookup journey or something, then wherever they reify that from request, maybe in an action helper thing - where they pass the wrapped enriched request they can replace the request with request
like
(replacing session.useServiceNav with however they want to resolve it)