DL-18572 Add RollNumber to Enter Details Page#1229
Open
mi-aspectratio wants to merge 8 commits intomainfrom
Open
DL-18572 Add RollNumber to Enter Details Page#1229mi-aspectratio wants to merge 8 commits intomainfrom
mi-aspectratio wants to merge 8 commits intomainfrom
Conversation
…encrypt session details transfer. rename save and fetch methods in details service
…. rename saving and get methods
# Conflicts: # app/controllers/bankdetails/UkBankAccountDetailsController.scala # conf/messages # test/forms/BankAccountDetailsFormSpec.scala
|
Jake-Raffe
reviewed
Mar 11, 2026
app/views/bankdetails/EnterCompanyBankAccountDetails.scala.html
Outdated
Show resolved
Hide resolved
Jake-Raffe
reviewed
Mar 11, 2026
Jake-Raffe
reviewed
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DL-18572: Add RollNumber to Enter Details Page
New feature
The field Roll number is added to the view
When the useBarsVerify is on these details are saved to session Cache which will be then presented on the next page for the user to confirm before sending details for verification.
Account Number and sort code are stored encrypted
Renamed method in Account details service to be more appropriate
Please include a summary / description of the change and which issue it fixes. Include any relevant user needs and context.
Checklist