fix(layers): Pass through opts.renderPass to @luma.gl model.draw
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
changed the title
opts.renderPassopts.renderPass to @luma.gl model.draw
Collaborator
|
I am ok with this but I don't really understand how it arose all of a sudden. |
Collaborator
|
(which is confusing) |
Member
Author
|
I was able to reproduce the error by upgrading deckgl/luma to v9.1 on main. So yes, the error was from upgrading to a server range we don't support. I guess the question is should we make this change and bump the semver range? |
ilan-gold
approved these changes
Jan 30, 2025
Collaborator
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
I guess the question is should we make this change and bump the semver range?
Right that's kind of what I was getting at, just wanted to make sure I understood. But if the current change works with 9.0 (and is actually what the API there calls for), then I think we can merge this PR, unless there is a reason not to. We can officially upgrade later.
xinaesthete
added a commit
to xinaesthete/viv
that referenced
this pull request
Apr 25, 2025
keller-mark
pushed a commit
that referenced
this pull request
Jun 17, 2025
* (chore) change deck/luma related dependencies * (fix) remove unused import createTestContext * (fix) pass opts.renderPass to model.draw, similar to #855 * (cosmetic) apply biome fix * remove redundant 'device' parameter in getRenderingAttrs * fix formatting * add changeset for release * use this.context.renderPass in line with deck.gl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #854, which I believe was introduced in #805.
Fixes #
Background
Change List
Checklist