Labels with single resolution image#273
Open
will-moore wants to merge 2 commits intohms-dbmi:mainfrom
Open
Conversation
Collaborator
Author
|
cc Kola @kbab whose image that is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digging into why labels at https://uk1s3.embassy.ebi.ac.uk/testbucket-bia/Diabetic_Biopsy_Human_Spectral_1-5300-2300_with_labels.ome.zarr/0 weren't showing up, it seems that labels are only displayed if the parent image has multiple dataset resolution levels (whereas that image only has a single resolution).
I don't know what the logic is there, but I made a couple of changes that allowed the labels to be displayed for that image.
Deployed at https://deploy-preview-273--vizarr.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/testbucket-bia/Diabetic_Biopsy_Human_Spectral_1-5300-2300_with_labels.ome.zarr/0