Skip to content

ssidToNetworkId should stop on first result#24

Open
dbalakirev wants to merge 1 commit intohoerresb:masterfrom
dbalakirev:master
Open

ssidToNetworkId should stop on first result#24
dbalakirev wants to merge 1 commit intohoerresb:masterfrom
dbalakirev:master

Conversation

@dbalakirev
Copy link

Hi,

Not a major thing but i believe there is no need to go on looking for SSID match if you already found one.

Cheers, Dave

@essboyer
Copy link

essboyer commented Jan 6, 2017

Hey Dave,
I feel you're correct here, however, I just wanted to note that there are cases where there are multiple SSIDs. For example, my ISP issues a residential gateway which has 3 networks with the same SSID - one 2.4 GHz, one 5 GHz for internet, one 5 Ghz for IPTV.

I'm currently working on adding support for duplicate SSIDs (via BSSID), and connecting to hidden (or empty) SSIDs, so note that in the meantime, you could get unexpected results both with the code currently in master, and with this fix.

Cheers,
Sean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants