ssidToNetworkId should stop on first result#24
Open
dbalakirev wants to merge 1 commit intohoerresb:masterfrom
dbalakirev:master
Open
ssidToNetworkId should stop on first result#24dbalakirev wants to merge 1 commit intohoerresb:masterfrom dbalakirev:master
dbalakirev wants to merge 1 commit intohoerresb:masterfrom
dbalakirev:master
Conversation
|
Hey Dave, I'm currently working on adding support for duplicate SSIDs (via BSSID), and connecting to hidden (or empty) SSIDs, so note that in the meantime, you could get unexpected results both with the code currently in master, and with this fix. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Not a major thing but i believe there is no need to go on looking for SSID match if you already found one.
Cheers, Dave