fix (win32): Invoking viewport_resize_callback at the very start#2523
Merged
hoffstadt merged 1 commit intohoffstadt:masterfrom Jun 23, 2025
Merged
Conversation
…es a regression in hoffstadt#2521).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Invoking
viewport_resize_callbackat the very startassignees: ''
Description:
This fixes a regression introduced in #2521. Prior to that PR, DPG was calling
viewport_resize_callbackat app start (on Windows), making it possible to dynamically resize GUI according to the actual client size of the viewport. It wasn't very stable and the callback was often called a dozen frames after startup, but was called anyway. PR 2521 changed that to a no-call. This PR brings the callback back, and also the call typically occurs on frame 1 (if Windows sendsWM_SIZEin time, which it typically does do).Concerning Areas:
None.