A better version of split_frame#2583
Merged
hoffstadt merged 1 commit intohoffstadt:masterfrom Jan 4, 2026
Merged
Conversation
…e rendering has ended.
hoffstadt
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: A better version of split_frame, releases immediately after frame rendering has ended.
assignees: ''
Description:
This PR improves on how
split_framewaits for a frame to get rendered: now there's no loop polling ondelayintervals (and nodelayargument at all), the function gets notified about the next frame immediately after its rendering has ended.Another effect of this PR is that
destroy_contextcauses any waitingsplit_frameto fail with an exception, whereas the earlier version would just hang up forever.Concerning Areas:
Users might need to adapt their code to catch or suppress exceptions, though 99.9% of them probably won't notice the change.