To improve the usefulness of the mvLogger for use with the logging module #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add demo to feed logs into mvLogger Set a distinct color for error_theme
jhgorse
suggested changes
Nov 28, 2023
jhgorse
left a comment
jhgorse
left a comment
There was a problem hiding this comment.
I like the idea. The bugfix is good.
The demo doesn't work though. Log events in the latest dpg do not forward to the console as intended via the queue.
Assemble the theme name fron the log level number Use log level constants
Author
|
More explicit setup of the logging module, including adding handler for console output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To improve the usefulness of the mvLogger for use with the logging module
Changes:
Match (mvLogger) log levels with module logging
Set a distinct color for error_theme
Add demo to feed (logging module) logs into mvLogger
Concerning Areas:
Do we want to add working examples under
if __name__ == "__main__":block?