Signed Lexicographic Integer & Date encoders#40
Open
lejeunerenard wants to merge 7 commits intomainfrom
Open
Conversation
Adds a byte before the `lexint` encoding that denotes if it is positive or negative.
Flipping the bits will preserve ordering for negative numbers.
Same as the `date` encoder, the date is encoded as milliseconds to epoch, but with a signed lexicographic integer encoder instead of a zig-zag integer encoder. Added test with assertion that will fail to order two dates if using the zig-zag encoder.
`signedLexint` was skipped since `lexint` isn't documented.
Contributor
Author
|
Discovered a bug where |
Included a test which uses the same buffer to encode a `lexdate` & `string` to showcase and test that `signedLexint` (used via `lexdate`) doesn't flip the bits after the date when decoding.
Contributor
Author
|
Fixed the issue & added a test that uses the same buffer to (en/de)code a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexicographic encoder for dates would be nice for range queries of timestamps. To support pre-epoch dates, a signed version of the
lexintencoder was needed.I initially opted to using the first byte for a boolean for whether the value is positive or not. But then adjusted a copy of the lexint (en/dec)coder so that it uses 1 bit from the first byte as the positive flag. This means the first byte can hold only a max magnitude of
122. The non-flag bits of negative numbers are flipped from their positive counterparts so the lexicographic ordering is preserved.