Skip to content

expose handshakeClearWait opt #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mafintosh merged 2 commits into from
Aug 6, 2025
Merged

expose handshakeClearWait opt #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c908c7
Support onfirewall callback for servers
HDegroote Aug 6, 2025
c31f651
Remove onfirewall approach
HDegroote Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ module.exports = class Server extends EventEmitter {
this.createHandshake = opts.createHandshake || defaultCreateHandshake
this.createSecretStream = opts.createSecretStream || defaultCreateSecretStream
this.suspended = false
this.handshakeClearWait = opts.handshakeClearWait || HANDSHAKE_CLEAR_WAIT

this._shareLocalAddress = opts.shareLocalAddress !== false
this._reusableSocket = !!opts.reusableSocket
Expand Down Expand Up @@ -423,7 +424,7 @@ module.exports = class Server extends EventEmitter {

_clearLater (hs, id, k) {
if (hs.clearing) return
hs.clearing = setTimeout(() => this._clear(hs, id, k), HANDSHAKE_CLEAR_WAIT)
hs.clearing = setTimeout(() => this._clear(hs, id, k), this.handshakeClearWait)
}

_clear (hs, id, k) {
Expand Down
13 changes: 13 additions & 0 deletions test/connections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,3 +792,16 @@ test('Populate DHT with options.nodes', async function (t) {
a.destroy()
b.destroy()
})

test('create server with handshakeClearWait opt', async function (t) {
const [a] = await swarm(t)

{
const server = a.createServer({ handshakeClearWait: 123 })
t.is(server.handshakeClearWait, 123)
}
{
const server = a.createServer({})
t.is(server.handshakeClearWait, 10000, 'expected default')
}
})
Loading