Add holepunching support on LAN#236
Open
supersuryaansh wants to merge 1 commit intoholepunchto:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on LAN after discovering that both peers are on LAN, the client just pings the server using a dht.ping() and waits for it to respond, however if the server is behind a firewall that ping never resolves and we throw a HOLEPUNCH_ABORTED error where we never actually holepunch.
This PR changes that and enables holepunching b/w LAN clients as well.
Info: I used AI to help me with this PR and I have written it to the best of my knowledge.