Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TIME-WAIT (from TCP) to libudx. The idea is to keep the socket active on the side that closes first (the 'active' closer) to retransmit the final ACK packet to the remote closer if necessary. without TIME-WAIT the stream would immediately close after sending an ACK for the final END packet; if this ACK is lost on the way to the remote closer, they would be left open until they time out.
One side effect of this change is the user callback
stream->on_close()is delayed on active close until the TIME-WAIT state times out. This may be a problem in real code (e.g. during shutdown) or in unit tests. The PR also adds a way to get and set the timeout time for each stream, setting it to 0 will allow streams to shutdown with minimal wait.