Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces 5 libuv timers with 1 libuv timer, based on the observation that only one of these timers need to be active at a time:
(4) Zero-Window probe and (5) KeepAlive can only be active if there are no packets in flight, ie all data has been acked. If the window size is zero then the ZWP timer is set instead of KeepAlive
(1) RTO, (2) TLP or (3) RACK_REO may be active when data is in flight.. The TLP is set when no loss is detected and the RACK_REO is set when potential loss (in the form of a SACK) is received, both of these timers reset the RTO timer on expiration.