Open
Conversation
Contributor
Didericis
commented
Jan 16, 2026
Didericis
commented
- mirror local files from the root of the pear project
Didericis
force-pushed
the
make-pear-dump-consistent
branch
from
ab5cd3c to
2037de0
Compare
Didericis
commented
Jan 16, 2026
| ? '' | ||
| : isFile | ||
| ? path.basename(parsed.pathname) | ||
| : prefix |
Contributor
Author
There was a problem hiding this comment.
Found this nested ternary a bit hard to read/moved the prefix and pathname declarations up
Didericis
commented
Jan 16, 2026
subsystems/sidecar/ops/dump.js
Outdated
| let prefix | ||
| let drive | ||
|
|
||
| if (!isFileLink) { |
Contributor
Author
There was a problem hiding this comment.
Effectively the same as if (corestore), but makes it so we can declare what the prefix and the drive should be for file protocol vs pear protocol
Didericis
force-pushed
the
make-pear-dump-consistent
branch
17 times, most recently
from
d46cb09 to
82f1f7b
Compare
- mirror local files from the root of the pear project
Didericis
force-pushed
the
make-pear-dump-consistent
branch
from
82f1f7b to
d116b31
Compare
Didericis
force-pushed
the
make-pear-dump-consistent
branch
from
59c046b to
9566aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.