Skip to content

Interactive widgets in header- fixes #8353#8357

Merged
philippjfr merged 5 commits intoholoviz:mainfrom
emunsing:8353_interactive_widgets_in_header
Feb 26, 2026
Merged

Interactive widgets in header- fixes #8353#8357
philippjfr merged 5 commits intoholoviz:mainfrom
emunsing:8353_interactive_widgets_in_header

Conversation

@emunsing
Copy link
Contributor

@emunsing emunsing commented Jan 4, 2026

Previous behavior: Previous #7057 specifically allowed TextInput objects in Card Headers, but the fix was specific to the TextInput widget and did not support any other interactive widgets (e.g. Select, Button, Slider, etc).

This PR, described in #8353 , generalizes based on CSS class to stop propagation of clicks which begin in any object which begins with bk-panel-models-widgets- which could be tweaked if needed to catch the right level of specificity (I defer to the repo owners; please provide feedback).

UI test has been updated (this updated test with a slider in the header was previously failing)

Linted and ran UI tests locally with no regressions, but this is my first PR on this repo!

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (c2047a7) to head (e77798d).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8357      +/-   ##
==========================================
- Coverage   86.12%   86.00%   -0.12%     
==========================================
  Files         349      349              
  Lines       54709    54968     +259     
==========================================
+ Hits        47116    47277     +161     
- Misses       7593     7691      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr mentioned this pull request Jan 26, 2026
@philippjfr philippjfr merged commit ab5adb3 into holoviz:main Feb 26, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants