Skip to content

Conversation

@emunsing
Copy link
Contributor

@emunsing emunsing commented Jan 4, 2026

1-liner fix to add a placeholder value to 8359. I'm not sure how to create a UI test for a placeholder value; happy to create one with help but given that this is a 1-line aesthetic change I don't know if that's needed.

@philippjfr
Copy link
Member

Thanks @emunsing, I don't think we really need a UI test, a simply unit test checking that the underlying model inherits the correct placeholder value should be sufficient.

@philippjfr
Copy link
Member

philippjfr commented Jan 5, 2026

def test_int_input_placeholder(document, comm):

    int_input = IntInput(placeholder='Foo", name='IntInput')

    widget = int_input.get_root(document, comm=comm)

    assert widget.active == "Foo"
    
    int_input.placeholder = "Bar"
    assert widget.placeholder == "Bar"

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (855143b) to head (1404713).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8360      +/-   ##
==========================================
- Coverage   86.09%   86.00%   -0.10%     
==========================================
  Files         349      349              
  Lines       54727    54734       +7     
==========================================
- Hits        47117    47073      -44     
- Misses       7610     7661      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
Copy link
Member

Thanks @emunsing, wanted to make sure you get the credit so just added the test here instead of making a new PR.

@philippjfr philippjfr merged commit 798a974 into holoviz:main Jan 20, 2026
21 checks passed
@philippjfr philippjfr mentioned this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants