Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
Meierschlumpf
left a comment
Meierschlumpf
left a comment
There was a problem hiding this comment.
I think something is broken when you choose a built in search engine:
Also we would need to add a user option if he wants to have ddg bangs
with schema validation and UI integration
Changes done, I fixed as much as I could, the commit fb15e1e is a bit big but it adds the user option to toggle on/off ddg bangs |
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_ddg-bangs.tsx
Outdated
Show resolved
Hide resolved
Replace generic Error with ResponseError from @homarr/common/server for better error handling consistency across the codebase.
Add JSDoc comment explaining why lowerBound uses binary search (O(log n)) instead of findIndex (O(n)) for searching ~13,000+ DuckDuckGo bangs.
Consolidate the DuckDuckGo bangs toggle into the existing search preferences form instead of having a separate form section. - Add ddgBangsEnabled to userChangeSearchPreferencesSchema - Update changeSearchPreferencesAsync to handle ddgBangs - Add toggle to ChangeSearchPreferencesForm component - Remove standalone DdgBangsForm component - Deprecate standalone changeDdgBangs endpoint (kept for API compat)
Generated migrations using pnpm db:migration:mysql:generate and pnpm db:migration:postgresql:generate for the ddgBangs user column.
|
@Meierschlumpf I addressed the changes, let me know if it works for you |
|
It almost works, but when disabling it then this is still shown: Also not sure if we should enable them by default |
This should be the default one, bangs will still work but not the ddg ones, can't disable built-in bangs |
|
Okay makes sense, can you fix the CI? Then we can merge IMO |
2 participants
What
Reworks Spotlight search to support !bang selection (configured engines + DuckDuckGo), and makes the default Spotlight view a launcher-like help screen.
Changes
Screenshots