perf(memory): combine websocket and tasks backend#4870
Draft
Meierschlumpf wants to merge 1 commit intodevfrom
Draft
perf(memory): combine websocket and tasks backend#4870Meierschlumpf wants to merge 1 commit intodevfrom
Meierschlumpf wants to merge 1 commit intodevfrom
Conversation
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
manuel-rw
approved these changes
Jan 19, 2026
Member
manuel-rw
left a comment
manuel-rw
left a comment
There was a problem hiding this comment.
Generally looks good, but be careful with potential breaking changes.
|
|
||
| const constructWebsocketUrl = () => { | ||
| const fallback = `${getWebSocketProtocol()}://localhost:3001/websockets`; | ||
| const fallback = `${getWebSocketProtocol()}://localhost:3002/websockets`; |
Member
There was a problem hiding this comment.
This will be a breaking change for Promox and other from-source installations, correct?
Member
Author
There was a problem hiding this comment.
No as they are also using the nginx proxy it should be fine
Member
Author
There was a problem hiding this comment.
I'll test it in different environments (my windows docker desktop and my NAS running linux with docker)
Member
|
Any update on this @Meierschlumpf ? |
Member
Author
|
No, sorry haven't worked on it for a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)In a test of multiple changes over 10 minutes where every 10 seconds it would call the docker containers endpoint of my main local homarr instance.
I got the following results:
Related to #3759