Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/page.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
...nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_general-settings-form.tsx
Outdated
Show resolved
Hide resolved
|
@Meierschlumpf I addressed the comments. In the end I switched to tanstack form for the form |
|
Why not mantine form with integrated zod validation from homarr/form? |
I didn't know we had @homarr/form xD |
|
@Meierschlumpf I moved to homarr form now, feel free to re-review whenever |
|
Can you please combine the mutations into one? |
This is outside of the scope of this PR imo, we made all of these mutations and used them before. |
rework the preferences screen
more pretty and has a prevention to not go out of the page by mistake with unsaved changes