feat(installations): support secrets file for all environment variables#5125
feat(installations): support secrets file for all environment variables#5125cethien wants to merge 1 commit intohomarr-labs:devfrom
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Feb 25, 2026 11:33a.m. | Review ↗ |
fd54810 to
3d4e5ae
Compare
|
Hi, thanks for the contribution. |
|
Hi, could be that my wording was wrong, english is not my native, sorry about that 😄 deploying homarr on swarm does work without issues, the "problem" is when working with in case of homarr when doing eg many containers support _FILE or __FILE alternatives for environment variables so figured would be cleaner that way and propably help others. since it mainly an entrypoint wrapper i dont think it should break anything either |
|
We already have this for the secret encryption key: Lines 23 to 25 in 12ba14b However I think it makes sense to support it for all environment variables. The only thing we have to decide in my opinion is if we
|
|
We probably should use something like this for the iteration: matching_var_names=$(env | cut -d '=' -f 1 | grep "_PATH$")
cat "$(echo ${!var})" |
okay, i checked and was in this case an error on my end, the version i had running was old and the run script didnt contain the
since this is not my project i let you guys decide. my 2 cents: |

was trying to deploy it in docker swarm with secret managment which doesnt work without some fragile entrypoint workaround.
added optional
__FILEsuffix for environment variables.also seems that its more or less a convention to use optional _FILE
sidenote: this was hacked together in a minute, tho in theory shouldnt break anything from a quick grep of the environment variables