Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Dec 3, 2024

Proposed Changes

validate_server_version was called frequently enough on my low volume systems that rest.py was number 7 in the profile when the system was relatively idle.

Its almost always going to be the same version so it can be cached

before
validate_server_version

after
after

validate_server_version was called frequently enough on
my low volume systems that it was number 7 in the profile

Its almost always going to be the same version so it can
be cached
@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (a135627) to head (cfe3fbf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   98.25%   98.27%   +0.02%     
==========================================
  Files           7        7              
  Lines         286      290       +4     
  Branches       19       19              
==========================================
+ Hits          281      285       +4     
  Misses          4        4              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added the performance Improving performance, not introducing new features. label Dec 3, 2024
@bdraco bdraco marked this pull request as ready for review December 3, 2024 19:26
@frenck frenck merged commit d26533b into main Dec 6, 2024
7 of 8 checks passed
@bdraco bdraco deleted the version_compare_all_the_time branch December 6, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

performance Improving performance, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants