Add supervisor APIs to client library #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add supervisor management APIs to the client library.
Note that this is the first one that differs in significant ways from the actual API. In the
infoAPI supervisor has marked the fieldswait_boot,addonsandaddons_repositoriesdeprecated for quite a while (seen here). Similarly with thewait_bootandaddons_repositoriesfields in theoptionsAPI (seen here). Therefore the client library will not add support for these deprecated fields.Although this seems non-controversial, they have been left around for so long because core and others use them still. So this will require refactoring to incorporate this part in core. And any others hoping to use the client library as a drop-in replacement for existing supervisor access.