Bump actions/download-artifact from 4 to 5

[dependabot]

Bumps actions/download-artifact from 4 to 5.

Release notes

Sourced from actions/download-artifact's releases.

v5.0.0

What's Changed

• Update README.md by @​nebuk89 in actions/download-artifact#407
• BREAKING fix: inconsistent path behavior for single artifact downloads by ID by @​GrantBirki in actions/download-artifact#416

v5.0.0

🚨 Breaking Change

This release fixes an inconsistency in path behavior for single artifact downloads by ID. If you're downloading single artifacts by ID, the output path may change.

What Changed

Previously, single artifact downloads behaved differently depending on how you specified the artifact:

• By name: name: my-artifact → extracted to path/ (direct)
• By ID: artifact-ids: 12345 → extracted to path/my-artifact/ (nested)

Now both methods are consistent:

• By name: name: my-artifact → extracted to path/ (unchanged)
• By ID: artifact-ids: 12345 → extracted to path/ (fixed - now direct)

Migration Guide

✅ No Action Needed If:

• You download artifacts by name
• You download multiple artifacts by ID
• You already use merge-multiple: true as a workaround

⚠️ Action Required If:

You download single artifacts by ID and your workflows expect the nested directory structure.

Before v5 (nested structure):

- uses: actions/download-artifact@v4
  with:
    artifact-ids: 12345
    path: dist
# Files were in: dist/my-artifact/

Where my-artifact is the name of the artifact you previously uploaded

To maintain old behavior (if needed):

</tr></table> 

... (truncated)

Commits

• 634f93c Merge pull request #416 from actions/single-artifact-id-download-path
• b19ff43 refactor: resolve download path correctly in artifact download tests (mainly ...
• e262cbe bundle dist
• bff23f9 update docs
• fff8c14 fix download path logic when downloading a single artifact by id
• 448e3f8 Merge pull request #407 from actions/nebuk89-patch-1
• 47225c4 Update README.md
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[MartinHjelmare]

There's a breaking change in this release and the migration guide doesn't explain how to migrate our use case and parameters (download all artifacts to the current directory).

It's not clear if this is a bug in v5 or just an incomplete migration guide.

[MartinHjelmare]

We could try changing this line to not look in a subdirectory (coverage*/):

python-supervisor-client/.github/workflows/ci.yaml

Line 330 in e039740

coverage combine coverage*/.coverage*

[agners]

There's a breaking change in this release and the migration guide doesn't explain how to migrate our use case and parameters (download all artifacts to the current directory).

It's not clear if this is a bug in v5 or just an incomplete migration guide.

Hm I see, weird indeed. I guess we only have one artifact we download, which triggers the new behavior as well.

I raised the unclear behavior in the offending PR at actions/download-artifact#416 (comment).

FWIW, our use here is a bit weird, we don't really use a matrix. So we can use explicit name and use a path to have consistent behavior.

[MartinHjelmare]

Yes, we could. But it's best practice to run the tests on all supported Python versions (currently at least Python 3.12 and 3.13). I'd rather extend our CI to do that than going the other way.

[agners]

Yes, we could. But it's best practice to run the tests on all supported Python versions (currently at least Python 3.12 and 3.13). I'd rather extend our CI to do that than going the other way.

Good point. It seems this GitHub Actions came from Supervisor, where we removed multiple Python versions a while back with home-assistant/supervisor#3864.

But for the client library we should follow Core's Python support stance.

[MartinHjelmare]

Yeah. And it's nice if we don't couple the change of supported versions too tightly to core, but can add a Python version when it get released and this library supports it and remove a supported Python version when core no longer supports it.

That way we aren't tightly tied to a specific point in time when we need to do maintenance here, more than that we should make sure to have support of a Python version before Home Assistant requires it.

With this in mind, being able to support more than a single Python version is good.

[agners]

@dependabot rebase

[dependabot]

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

[agners]

We typically pin versions explicitly.