Fix type of Addon.ip_address #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
approved these changes
Oct 1, 2024
Collaborator
agners
left a comment
agners
left a comment
There was a problem hiding this comment.
Unfortunately this is a breaking change since it appears mashumaro allowed a string in despite the typing [...]
Hm, so this is why it did not blow up I guess? 🤔
I think that's ok since we're still in very early versions but I can make a str if we prefer.
So the breaking change here is towards the client right? Since the current data type is really wrong, and we are early, I agree, this breaking change is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Typing of
ip_addressfield in Addon info was completely incorrect, it is not abool. Unfortunately this is a breaking change since it appears mashumaro allowed a string in despite the typing and now it is correctly made into anIPv4Address. I think that's ok since we're still in very early versions but I can make astrif we prefer.