Vlan parent can be None
#82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdegat01
added
the
bugfix
MartinHjelmare
approved these changes
Apr 10, 2025
agners
approved these changes
Apr 11, 2025
Collaborator
agners
left a comment
agners
left a comment
There was a problem hiding this comment.
It is a bit unclear to me if parent really can be None from the D-Bus Vlan Device description.
However, a quick check with a USB network device confirms that:
VLAN when USB network device was plugged in:
.Parent property o "/org/freedesktop/NetworkManager/Device… emits-change
After removing
.Parent property o "/" emits-change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Vlan parent interface can be
Noneaccording to NM documentation.