Skip to content

Conversation

@AlCalzone
Copy link
Contributor

@AlCalzone AlCalzone commented Nov 25, 2025

https://zwave-js.github.io/zwave-js/#/api/node?id=quotnode-info-receivedquot

This is forwarded by the server starting in v3.5.0

@AlCalzone AlCalzone marked this pull request as ready for review November 25, 2025 10:13
@MartinHjelmare
Copy link
Contributor

Let's add a test similar to this test:

async def test_driver_ready_event(driver):
"""Test that the driver ready event is succesfully validated by pydantic."""
event_type = "driver ready"
event_data = {"source": "driver", "event": event_type}
event = Event(event_type, event_data)
def callback(data: dict) -> None:
assert data == event_data
driver.on(event_type, callback)
driver.receive_event(event)

@MartinHjelmare MartinHjelmare marked this pull request as draft November 27, 2025 16:12
@vexofp
Copy link

vexofp commented Dec 20, 2025

Eagerly awaiting this PR to land, be released, and make its way in to Home Assistant. 🙏

Some of my older GE switches like to generate this event quite often. The missing entry in NODE_EVENT_MODEL_MAP causes Node.receive_event() to throw, causing the Home Assistant integration to disconnect/reload, causing all entities to become temporarily unavailable and generally causing mischief with automations as the states repopulate afterward.

Testing this patch locally, it successfully resolves the issue.

@AlCalzone AlCalzone marked this pull request as ready for review January 2, 2026 10:34
@AlCalzone
Copy link
Contributor Author

The missing entry in NODE_EVENT_MODEL_MAP causes Node.receive_event() to throw, causing the Home Assistant integration to disconnect/reload

@MartinHjelmare this is concerning. I suppose we should ignore new/unknown events, not crash.

@MartinHjelmare
Copy link
Contributor

Yes, sounds good. A separate PR with that is welcome.

Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit e993a21 into home-assistant-libs:main Jan 2, 2026
5 checks passed
@AlCalzone
Copy link
Contributor Author

Yes, sounds good. A separate PR with that is welcome.

#1348

@AlCalzone AlCalzone deleted the node-info-received branch January 2, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants