-
Notifications
You must be signed in to change notification settings - Fork 22
Add support for node info received event
#1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node info received event
#1329
Conversation
|
Let's add a test similar to this test: zwave-js-server-python/test/model/test_driver.py Lines 398 to 408 in 0644630
|
|
Eagerly awaiting this PR to land, be released, and make its way in to Home Assistant. 🙏 Some of my older GE switches like to generate this event quite often. The missing entry in Testing this patch locally, it successfully resolves the issue. |
@MartinHjelmare this is concerning. I suppose we should ignore new/unknown events, not crash. |
|
Yes, sounds good. A separate PR with that is welcome. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
https://zwave-js.github.io/zwave-js/#/api/node?id=quotnode-info-receivedquot
This is forwarded by the server starting in v3.5.0