Added additional ports that can be used for custom servers.#4403
Added additional ports that can be used for custom servers.#4403loewexy wants to merge 2 commits intohome-assistant:masterfrom
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
📝 WalkthroughWalkthroughAdded documentation, configuration, and English translation entries declaring three additional TCP ports (8443, 8444, 8445) for custom servers; no runtime logic or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I fixed the two nitpick comments from CodeRabbit review, i think the new version makes it better to understand for users. |
The addon currently allows only exposing ports 80 and 443. But it allows the user to add custom servers. If one of those should use another port this is not possible using the addon. Nginx will boot and listen to the port but there is no way to expose that port.
To fix this I suggest adding 3 custom ports, that can be used by the use for custom servers. From my point of view it is okay to just offer some ports since it is easy for the user to select the exact port that should be opened on the host outside the container via the addon config.
I know it is currently possible to have multiple server {} directives differentiating via the name but for some use cases this is not enough. My actual use case for which i think this is the perfect solution is requiring client cert authentication when connecting from the internet. For that i can configure a second server that enforces client cert auth and make the port forwarding in the router to this port. This is only hindered by the missing possibility to expose the second port.
Please let me know if the pull request can be improved i am happy to fix your remarks.
Summary by CodeRabbit
Documentation
Configuration