Skip to content

Added additional ports that can be used for custom servers.#4403

Open
loewexy wants to merge 2 commits intohome-assistant:masterfrom
loewexy:add-custom-ports
Open

Added additional ports that can be used for custom servers.#4403
loewexy wants to merge 2 commits intohome-assistant:masterfrom
loewexy:add-custom-ports

Conversation

@loewexy
Copy link

@loewexy loewexy commented Feb 8, 2026

The addon currently allows only exposing ports 80 and 443. But it allows the user to add custom servers. If one of those should use another port this is not possible using the addon. Nginx will boot and listen to the port but there is no way to expose that port.

To fix this I suggest adding 3 custom ports, that can be used by the use for custom servers. From my point of view it is okay to just offer some ports since it is easy for the user to select the exact port that should be opened on the host outside the container via the addon config.

I know it is currently possible to have multiple server {} directives differentiating via the name but for some use cases this is not enough. My actual use case for which i think this is the perfect solution is requiring client cert authentication when connecting from the internet. For that i can configure a second server that enforces client cert auth and make the port forwarding in the router to this port. This is only hindered by the missing possibility to expose the second port.

Please let me know if the pull request can be improved i am happy to fix your remarks.

Summary by CodeRabbit

  • Documentation

    • Clarified that ports 8443, 8444 and 8445 are available for custom server use and should be enabled in network settings.
  • Configuration

    • Added three TCP port entries (8443, 8444, 8445) for custom server configuration.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @loewexy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft February 8, 2026 15:39
@home-assistant
Copy link

home-assistant bot commented Feb 8, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@loewexy loewexy marked this pull request as ready for review February 8, 2026 15:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

Added documentation, configuration, and English translation entries declaring three additional TCP ports (8443, 8444, 8445) for custom servers; no runtime logic or behavioral changes.

Changes

Cohort / File(s) Summary
Port configuration & docs
nginx_proxy/DOCS.md, nginx_proxy/config.yaml, nginx_proxy/translations/en.yaml
Introduced three new TCP port entries: 8443/tcp, 8444/tcp, 8445/tcp. config.yaml contains the port keys with null values; DOCS.md and en.yaml include descriptive text indicating these ports are available for custom servers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding three new ports (8443, 8444, 8445) for custom servers across documentation, configuration, and translations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@loewexy
Copy link
Author

loewexy commented Feb 8, 2026

I fixed the two nitpick comments from CodeRabbit review, i think the new version makes it better to understand for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant