refactor: respect HTML Semantic Elements and clean style#1024
Merged
frenck merged 2 commits intohome-assistant:devfrom Feb 5, 2026
Merged
refactor: respect HTML Semantic Elements and clean style#1024frenck merged 2 commits intohome-assistant:devfrom
frenck merged 2 commits intohome-assistant:devfrom
Conversation
fe0c49f to
26981e6
Compare
Merged
Quentame
commented
Oct 27, 2025
ludeeus
pushed a commit
that referenced
this pull request
Nov 11, 2025
26981e6 to
87c862d
Compare
87c862d to
c4bb1f8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the HTML structure to use semantic HTML5 elements (header, nav, main, footer) instead of generic divs, consolidates the container structure to a single wrapper, and removes unused CSS rules. The changes improve code maintainability and follow HTML5 best practices.
Changes:
- Replaced generic div elements with semantic HTML5 elements (header, nav, main, footer) in the base layout
- Consolidated three separate container divs into a single container wrapping all content
- Removed unused CSS rules (.logo, .initiative, nav-bar img styles) and duplicate properties
- Improved template variable formatting for consistency (spacing around
{{and}})
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/src/_layouts/base.html | Refactored to use semantic HTML elements and improved template formatting; consolidated container structure |
| site/src/_static/styles.css | Removed unused CSS classes and duplicate properties; improved responsive design organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frenck
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect HTML Semantic Elements: https://www.w3schools.com/html/html5_semantic_elements.asp
Before
After
Also permits to manage only one
.containerfor all pages..containerdesign inspired from the Bootstrap framework : https://getbootstrap.com/docs/5.3/layout/containers/Clean unused / doubled CSS rules
Also contains some formating of
base.htmlas #1025 did for other HTML files