Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Mar 17, 2025

Summary

This PR is adding the necessary configuration in order to run instrumentation test on all the platform we support. I've created a very simple test that simply start the LauncherActivity and SplashScreenActivity it is already a good start and could save us from some crashes since it's going to test min and max versions for each platform.

Any other notes

I selected different version of API while always including min and max.
Automotive is ready but we can't run test until theses PRs are not merged ReactiveCircus/android-emulator-runner#428 and ReactiveCircus/android-emulator-runner#429

From now on the test comment on the PR is only shown on failure of a test.

In addition now that we use a lot of runners, in order to avoid waste of resources I've made sure that no workflows are running in // for the same PR. It means that if we push a commit while a workflow is running on an opened PR the running workflow is going to be canceled.

@jpelgrom
Copy link
Member

(Do we need the comment each time? E.g. some projects only post it if a test fails.)

@TimoPtr
Copy link
Member Author

TimoPtr commented Mar 17, 2025

(Do we need the comment each time? E.g. some projects only post it if a test fails.)

I need to check the settings but probably.

@TimoPtr
Copy link
Member Author

TimoPtr commented Mar 17, 2025

Currently the Github action that we use does not expose a way to create an automotive AVD I've opened a PR on their repository ReactiveCircus/android-emulator-runner#428

@TimoPtr TimoPtr changed the title Add dummy instrumentation test for app/automotive/wear Add dummy instrumentation test for app/automotive/tv/wear Mar 18, 2025
@home-assistant home-assistant deleted a comment from github-actions bot Mar 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

Test Results

13 files  13 suites   1m 1s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
18 runs  18 ✅ 0 💤 0 ❌

Results for commit a58f47a.

♻️ This comment has been updated with latest results.

@TimoPtr TimoPtr requested review from dshokouhi and jpelgrom March 18, 2025 10:39
@TimoPtr TimoPtr marked this pull request as ready for review March 18, 2025 10:39
@jpelgrom
Copy link
Member

The title notes app/automotive/tv/wear but:

  • automotive is disabled, correct?
  • there is no tv, correct? (In my opinion we should not test for this because we do not support it, mainly due to frontend limitations)

@TimoPtr
Copy link
Member Author

TimoPtr commented Mar 19, 2025

The title notes app/automotive/tv/wear but:

* automotive is disabled, correct?

* there is no tv, correct? (In my opinion we should not test for this because we do not support it, mainly due to frontend limitations)

Automotive is indeed disabled, with the PR that I've opened on the Action we should get it. About tv I did add one target just to verify it doesn't crash, I think it's good to know the status of the platform even if for now we didn't put a lot of effort into it (from the UX point of view).
We could make the check of TV optional.

Updating the title to remove automotive

@TimoPtr TimoPtr changed the title Add dummy instrumentation test for app/automotive/tv/wear Add dummy instrumentation test for app/tv/wear Mar 19, 2025
@TimoPtr TimoPtr merged commit b597850 into master Mar 19, 2025
13 checks passed
@TimoPtr TimoPtr deleted the feature/dummy_instrumentation_test_for_app branch March 19, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants