-
-
Notifications
You must be signed in to change notification settings - Fork 874
Add dummy instrumentation test for app/tv/wear #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(Do we need the comment each time? E.g. some projects only post it if a test fails.) |
I need to check the settings but probably. |
|
Currently the Github action that we use does not expose a way to create an automotive AVD I've opened a PR on their repository ReactiveCircus/android-emulator-runner#428 |
Test Results13 files 13 suites 1m 1s ⏱️ Results for commit a58f47a. ♻️ This comment has been updated with latest results. |
This reverts commit 502453d.
|
The title notes app/automotive/tv/wear but:
|
Automotive is indeed disabled, with the PR that I've opened on the Action we should get it. About tv I did add one target just to verify it doesn't crash, I think it's good to know the status of the platform even if for now we didn't put a lot of effort into it (from the UX point of view). Updating the title to remove automotive |
Summary
This PR is adding the necessary configuration in order to run instrumentation test on all the platform we support. I've created a very simple test that simply start the
LauncherActivityandSplashScreenActivityit is already a good start and could save us from some crashes since it's going to test min and max versions for each platform.Any other notes
I selected different version of API while always including min and max.
Automotive is ready but we can't run test until theses PRs are not merged ReactiveCircus/android-emulator-runner#428 and ReactiveCircus/android-emulator-runner#429
From now on the test comment on the PR is only shown on failure of a test.
In addition now that we use a lot of runners, in order to avoid waste of resources I've made sure that no workflows are running in // for the same PR. It means that if we push a commit while a workflow is running on an opened PR the running workflow is going to be canceled.