Websocket react on URL change

[TimoPtr]

Summary

This is an attempt to make the Websocket impl to react to a URL change.

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

This is an attempt because I'm not sure it is actually doing anything, I don't know if there are a use case where the URL change that is not already disconnecting the web socket. Maybe if the internal is still accessible, but changing wifi SSID does disconnect briefly the WS already.

[jpelgrom]

I don't know if there are a use case where the URL change that is not already disconnecting the web socket.

Changing from 5G (with public URL that also works when at home) to Wi-Fi (with internal IP) doesn't immediately trigger a disconnect for me, it takes the system a while to actively stop using 5G for network access for active connections and disconnect the websocket. With this change, I suppose that may happen sooner from the app's end now instead of waiting for the system to disconnect + the app to notice?

[jpelgrom]

• Maybe introduce WebSocketState.CLOSED_URL_CHANGE for this?
• In case the URL changes, do we want the same delay for reconnecting (10s) or none / a shorter delay?

[TimoPtr]

Done 👍🏻

[TimoPtr]

If it's easy for you to test with 5G lemme know how it behaves on your side.

[jpelgrom]

Shouldn't be too difficult, I'll test it tomorrow

[TimoPtr]

I don't know if there are a use case where the URL change that is not already disconnecting the web socket.

Changing from 5G (with public URL that also works when at home) to Wi-Fi (with internal IP) doesn't immediately trigger a disconnect for me, it takes the system a while to actively stop using 5G for network access for active connections and disconnect the websocket. With this change, I suppose that may happen sooner from the app's end now instead of waiting for the system to disconnect + the app to notice?

Interesting, in that case I'm curious if you could test if you see a difference. I only tested changing Wi-Fi to another one.

[jpelgrom]

Sorry for the late response: testing when switching between 5G/Wi-Fi now shows immediate disconnects, with the system also immediately switching to the new connection when the websocket is restarted, and also immediate disconnects for trusted Wi-Fi/other Wi-Fi.

Testing note: if the websocket is returning a null URL it should probably be handled in the WebSocketManager's job to not indicate a connection in the notification while there is actually none, but that is out of scope of this PR.