Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Jan 5, 2026

Summary

Move the migration into a dedicated file to make it easier to see the database configuration. Add instrumentation test for the migration, for now it only tests migration from 24 to latest. Later we should add individual tests for migrations to verify the behavior.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

@TimoPtr TimoPtr requested a review from jpelgrom January 5, 2026 12:39
Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I'm not convinced this is all a cleanup, everything you moved was already at the end of the file. The automated test is nice though.

@TimoPtr
Copy link
Member Author

TimoPtr commented Jan 7, 2026

To be honest I'm not convinced this is all a cleanup, everything you moved was already at the end of the file. The automated test is nice though.

Well I wanted to have only the database definition in the file to make it cleared. Migration is something else IMO, I hesitated to create a file for each migration, but I decided that for now it's fine like this.

For large migration or complex one I would like one file and one associated test for instance.

…base/migration/DatabaseMigration.kt

Co-authored-by: Joris Pelgröm <[email protected]>
@TimoPtr TimoPtr requested a review from jpelgrom January 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants