Skip to content

Continue migration of methods from handler to aiohasupervisor #129183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2024
Merged

Continue migration of methods from handler to aiohasupervisor #129183

merged 5 commits into from
Oct 29, 2024

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Oct 25, 2024 •
edited
Loading

Proposed change

Migrate more methods from hassio/handler to aiohasupervisor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mdegat01 mdegat01 requested review from a team, bdraco, emontnemery and jbouwh as code owners October 25, 2024 19:23
@home-assistant
Copy link

home-assistant bot commented Oct 25, 2024

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Oct 25, 2024

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Oct 25, 2024

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Oct 25, 2024

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mdegat01 mdegat01 force-pushed the handler-to-aiohasupervisor-cont branch from 3ce22f9 to c9abc20 Compare October 25, 2024 19:24
mdegat01
mdegat01 commented Oct 25, 2024
View reviewed changes
tests/components/hassio/test_init.py
await hass.async_block_till_done()

assert aioclient_mock.call_count + len(supervisor_client.mock_calls) == 24
assert aioclient_mock.call_count + len(supervisor_client.mock_calls) == 25
Copy link
Contributor Author

@mdegat01 mdegat01 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers - Previously tests were mocking the HassIO.is_connected method rather then the url supervisor/ping so that call was not included in this count. Now that method in the library is being mocked just like all the others so the count increases by one.

@mdegat01 mdegat01 requested a review from a team as a code owner October 26, 2024 02:47
@mdegat01 mdegat01 force-pushed the handler-to-aiohasupervisor-cont branch from 998de29 to 51661f6 Compare October 26, 2024 02:48
mdegat01
mdegat01 commented Oct 26, 2024
View reviewed changes
homeassistant/components/hassio/handler.py
return await hassio.send_command(
command,
payload={"version": version},
timeout=None,
Copy link
Contributor Author

@mdegat01 mdegat01 Oct 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers - yes this change remove these overrides of the default timeout of 10s. I discussed it with Martin and all these timeout overrides for specific methods will be incorporated in the library. It will set appropriate timeouts for each API call for clients instead of asking them for a default timeout. This change will be made in home-assistant-libs/python-supervisor-client#23 and incorporated into the next release of the library.

jbouwh
jbouwh approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mqtt,
Thanks @mdegat01 👍

@joostlek joostlek merged commit 673f022 into dev Oct 29, 2024
46 checks passed
@joostlek joostlek deleted the handler-to-aiohasupervisor-cont branch October 29, 2024 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joostlek joostlek joostlek approved these changes

@jbouwh jbouwh jbouwh approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@jbouwh jbouwh

@emontnemery emontnemery

Labels

by-code-owner cla-signed code-quality core Hacktoberfest has-tests integration: hassio integration: matter integration: mqtt integration: zwave_js Quality Scale: internal Quality Scale: No score Quality Scale: platinum

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mdegat01 @joostlek @jbouwh @bdraco @emontnemery