-
-
Notifications
You must be signed in to change notification settings - Fork 35.1k
Add MCF (1000 Cubic Feet) as an alternate unit of measure for volume #150015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is at least how my natural gas utility tracks and bills my usage, rather than in CCF or other existing units.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
The supported unites get sorted si I need to do that too.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
The failing test in the kitchen sink integration is related and needs to be updated. |
requested changes are applied
Proposed change
This is at least how my natural gas utility tracks and bills my usage, rather than in CCF or other existing units.
This seems to be at least somewhat common in the US for tracking billable usage for Gas and Water.
Similar past PR:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: