Skip to content

Conversation

@TheJulianJES
Copy link
Member

Proposed change

Change ZHA's config flow to ignore the Home Assistant Connect ZWA-2 (Z-Wave) adapter in the serial port selector.
This is done by implementing a new IGNORED_USB_DEVICES set with (manufacturer, usb_description) tuples and known Nabu Casa Z-Wave adapter names (ZWA-2).

Additional notes

Something similar was already done for the Z-Wave integration with:

Similar explanation on implementation to Z-Wave PR (CLICK TO OPEN)

Note: We cannot use VID/PID for this, as ZWA-2 and early ZBT-2 units share the same VID/PID.

For the Z-Wave PR linked below, I've also looked at fetching this info from USB discovery for Home Assistant hardware and ZHA/Z-Wave integrations, but that adds a lot of complexity and weird dependencies. This simple solution seems better and avoids any false-positives (e.g. ignoring a Zigbee + Z-Wave adapter with the same USB info).

In the future, we wanna look at implementing a (custom) serial port selector in the frontend, also used by integrations for other Open Home Protocols. This/similar logic might be moved to that serial port selector then.
For now, this PR implements a simple way of hiding known non Zigbee devices. Other manufacturers can also be added.

Semi-related backlog issue:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants