-
-
Notifications
You must be signed in to change notification settings - Fork 36.6k
Fix Thread dataset update logic when only timestamp ticks change #159769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b124b00 to
2fe6827
Compare
The previous check `old.seconds >= new.seconds` caused the function to return early if seconds were equal, skipping the comparison of ticks. This prevented datasets from updating if the timestamp only advanced by ticks. Switching to tuple comparison `(seconds, ticks)` fixes the order of operations. Fixes parts of home-assistant#134306 Additionally needs a library update to fix faulty timestamp parsing.
607cbdd to
00385d5
Compare
|
Please don’t use force-push. |
balloob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
The previous check
old.seconds >= new.secondscaused the function to return early if seconds were equal, skipping the comparison of ticks. This prevented datasets from updating if the timestamp only advanced by ticks. Switching to tuple comparison(seconds, ticks)fixes the order of operations.Fixes parts of #134306
Additionally needs a library update to fix faulty timestamp parsing.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: