Skip to content

Conversation

@MartB
Copy link
Contributor

@MartB MartB commented Dec 26, 2025

Proposed change

The previous check old.seconds >= new.seconds caused the function to return early if seconds were equal, skipping the comparison of ticks. This prevented datasets from updating if the timestamp only advanced by ticks. Switching to tuple comparison (seconds, ticks) fixes the order of operations.

Fixes parts of #134306
Additionally needs a library update to fix faulty timestamp parsing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartB MartB requested a review from a team as a code owner December 26, 2025 07:19
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MartB

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 26, 2025 07:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (thread) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of thread can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign thread Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartB MartB marked this pull request as ready for review December 26, 2025 07:34
@MartB MartB force-pushed the fix-thread-timestamp branch from b124b00 to 2fe6827 Compare December 26, 2025 13:48
@lboue lboue changed the title Fix dataset update logic when only timestamp ticks change Fix Thread dataset update logic when only timestamp ticks change Dec 26, 2025
The previous check `old.seconds >= new.seconds` caused the function to return early if seconds were equal, skipping the comparison of ticks.
This prevented datasets from updating if the timestamp only advanced by ticks.
Switching to tuple comparison `(seconds, ticks)` fixes the order of operations.

Fixes parts of home-assistant#134306
Additionally needs a library update to fix faulty timestamp parsing.
@MartB MartB force-pushed the fix-thread-timestamp branch from 607cbdd to 00385d5 Compare December 28, 2025 16:18
@lboue
Copy link
Contributor

lboue commented Dec 28, 2025

Please don’t use force-push.
That's going to break the code review.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit baa4685 into home-assistant:dev Dec 28, 2025
36 checks passed
@MartB MartB deleted the fix-thread-timestamp branch December 29, 2025 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants