-
-
Notifications
You must be signed in to change notification settings - Fork 36.6k
Add config flow to OPNsense integration #160161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add config flow to OPNsense integration #160161
Conversation
- Add GUI-based configuration flow with interface and device selection - Add data update coordinator for efficient data fetching - Support reconfiguration of interfaces and tracked devices - Automatically remove entities when deselected during reconfiguration - Add comprehensive test coverage for config flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @mtreinish, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
NoRi2909
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick notes from a translator's perspective.
Main point to also use sentence-casing for title strings in HA.
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
I totally agree with you, it makes prefect sense! Thanks for your contribution |
|
Thanks for submitting your PR! Just checking, but isn't this a possible duplicate of: #151121? |
I'm afraid it acqually is, this one looks a bit more customizable, not only interface selection but also device selection too, the current integration just adds all of the devices as trackers and it's a bit counter intuitive IMO. My bad for not checking for duplicates before submitting the PR. |
|
It's a pity you put all this work into it. Maybe you can help the first sugnmitter with a useful review? :) |
…er provided' message - Remove check that prevented recreating existing entities during setup - All entities are now recreated during reload, not just new or offline ones - This ensures Home Assistant recognizes all entities as still being provided
…tdeepred/core into opnsense-config-flow-improvements
|
That’s a fair point! However, given that the other PR has been quiet for a few months, I went ahead and implemented the device selection logic I was looking for. I’m actually using it right now via HACS (https://github.com/itsjustdeepred/opnsense-hacs) and it works like a charm. I think it adds some value that #151121 is currently missing, so I'd love to keep this version on the table if possible. |
Breaking change
No breaking changes. This PR maintains full backward compatibility with existing YAML configurations.
Proposed change
Add GUI-based configuration flow to OPNsense integration, allowing users to:
The implementation includes:
This enhancement improves the user experience by eliminating the need for manual YAML configuration while maintaining full backward compatibility.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: