-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Move condition to prioritize preset mode (eco/comfort...) instead of program name in Overkiz #160189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hey there @iMicknl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the logic for determining the preset mode of Atlantic electrical heaters in the Overkiz integration. The change prioritizes the target heating level (eco, comfort, etc.) over the operating mode when determining the current preset, allowing users to see the actual heating level even when the heater is in external control mode.
Key changes:
- Reordered conditional checks in the
preset_modeproperty to checkIO_TARGET_HEATING_LEVELstate beforeCORE_OPERATING_MODE - This enables automation based on actual preset modes (eco/comfort) rather than just "external" when heaters are externally controlled
|
Why is this classified as a breaking change? It renders the integration no longer backwards incompatible? :) |
iMicknl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @orandin!
Technically, a breaking change is one that alters behavior for existing users of the integration. This change sits somewhat in between. It addresses an existing issue, which makes it feel like a bug fix, but it does introduce a different user-facing behavior. I’ll check with the other core contributors whether this should be treated as a breaking change or documented as a bug fix instead.
|
In my experience it would be considered a breaking change, if a user has to do something in order to fix it, or when a functionality no longer is available. If new behavior is implemented and works right away when updating, but doesn't affect the two mentioned points it's not a breaking change in my books - it's working as intended without any impact. :) |
|
@iMicknl Would you prefer that I remove the breaking change section? |
eb1a9a1 to
dbce337
Compare
For external program only:
Proposed change
The external mode means the heater is managed by external controller (e.g. home assistant). However, it is currently impossible to know the current preset mode (eco, comfort, ...) in this mode. Automation is not possible (e.g. select all heaters in specific preset to set another preset)
The idea is to move condition to prioritize preset mode (eco/comfort...) instead of program name (external).
Screenshots :
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: