-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add documentation for nested field translations #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for nested field translations #2791
Conversation
📝 WalkthroughWalkthroughAdded SSH configuration to the add-on schema with public_key and private_key fields, and introduced corresponding UI translations (name, description, field labels). Existing SSL documentation remains unchanged. No exported or public entity declarations were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/add-ons/configuration.md (1)
303-313: Tighten field descriptions to set expected formats.Clarify formats to reduce user error and align with common SSH key types.
ssh: name: SSH Options - description: Configure SSH authentication options + description: Configure SSH authentication options fields: public_key: name: Public Key - description: Client Public Key + description: OpenSSH public key (e.g., ssh-ed25519, ecdsa, rsa) private_key: name: Private Key - description: Client Private Key + description: PEM-encoded private key (will be hidden in UI)Confirm the frontend renders nested field translations as shown for objects (key:
sshwith subfields) per home-assistant/frontend#26997.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/add-ons/configuration.md(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
|
I'm ignoring the AI code review comments, because it thinks this PR is actually about SSH keys... |
Proposed change
Add documentation for nested field translations (new feature).
See home-assistant/frontend#26997 and home-assistant/supervisor#6180 for context.
Type of change
Checklist
Additional information