Skip to content

Add page to explain the roles in developing #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add page to explain the roles in developing #2802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e56e957
Add page to explain the roles in developing
joostlek Sep 23, 2025
1f6139c
Add page to explain the roles in developing
joostlek Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions docs/development_roles.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
title: "Roles in development"
---

During development of Home Assistant integrations, you will come across different roles that are involved in the process. This document explains these roles and their responsibilities.

## Core members

Core members are contributors with write access to the Home Assistant Core repository.
Copy link
Member

@balloob balloob Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Core members are contributors with write access to the Home Assistant Core repository.
Core members, identified by the "member" label, are contributors with write access to the Home Assistant Core repository.

Copy link
Member

@balloob balloob Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I would add another sentence. They are members of the core team maintaining Home Assistant.

They have the ability to review and merge pull requests, manage issues, and maintain the overall quality of the codebase.
Core members are responsible for ensuring that contributions adhere to the project's guidelines and standards.

## Integration owners

Formerly known as "codeowners", integration owners are core members who have taken on the responsibility of maintaining specific integrations within Home Assistant.
Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also mention the relevant ADR

Copy link
Member

@balloob balloob Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why mention how it was formerly known and as first sentence ? Is it important to know?

Copy link
Member

@balloob balloob Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration owners don't need to be code owners

Copy link
Member

@frenck frenck Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not agreeing on the last comment @balloob. How would that work? Someone just shouts; " I own this things?".

There needs to be some for of tracking here.

Copy link
Member

@abmantis abmantis Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration owners are core members

Integration owners are not "Core members"

Comments and concerns raised by integration owners are held in high regard, as they possess in-depth knowledge of the integration they oversee.
Integration owners are mentioned in every pull request that changes the code of their integration, and in every issue that is opened for their integration.
Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda want to emphasize that integration owners don't have a final say in what they approve or create for their integration. That still lies with the members.

Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestions welcome btw)

Copy link
Member

@balloob balloob Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "mentioned" is github jargon. Use word notified.

Also. Platinum integrations require code owners approval so there definitely is something to say. I think this text downplays their role, making it less appealing to become one!


## Core team
Copy link
Member

@frenck frenck Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the higher level names and clearly distinguish the OHF part in the role names.

The HA GitHub org is currently already reflecting that.

That said; I do want to change the naming fully for this one, and consider forming sn architectural group of some sort.


The core team is a group of developers responsible for the overall direction and management of the Home Assistant Core project.
They are employed by The Open Home Foundation.
Copy link
Member

@abmantis abmantis Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
They are employed by The Open Home Foundation.
They are employed by the Open Home Foundation.

The core team generally meets every week to discuss pull requests and architectural proposals.
Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the members of the core team?

Copy link

@missyquarry missyquarry Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that aligns with our working in the open, but I also tend to leave it up to our colleagues if they want to be that out in the open. Would linking to the org member list work in this case, or are Members included there?

Copy link
Member

@frenck frenck Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the team in GitHub instead.

Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the moment of meeting?

Copy link
Member

@frenck frenck Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed; just mention of a weekend cadence should be good enough

Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add that if people have strong concerns, that they can ask for a PR to be discussed here?

Copy link

@missyquarry missyquarry Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fair to do. You mean strong concerns against a change, right, not just this update?

Copy link
Member Author

@joostlek joostlek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when someone thinks they are in an impasse because they think something is reasonable and they have proper arguments (or examples where something similar happened) that would warrant a discussion

Copy link
Member

@frenck frenck Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what architecture discussion or for.

1 change: 1 addition & 0 deletions sidebars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ module.exports = {
],
Core: [
"development_index",
"development_roles",
{
type: "category",
label: "Architecture",
Expand Down