Migrate ha-icon-picker to generic picker #27677
Open
+105
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFreeze
reviewed
Oct 28, 2025
timmo001
commented
Oct 28, 2025
| allow-custom-value | ||
| .dataProvider=${ICONS_LOADED ? this._iconProvider : undefined} | ||
| .getItems=${this._getItems} | ||
| .label=${this.label} |
Member
Author
There was a problem hiding this comment.
The new picker label looks out of place next to textfields now
Member
Author
There was a problem hiding this comment.
Original for reference:
the icon is also missing, this is due to the placeholder vs value problem
The main issue for me is the label being outside the textfield now. Maybe an alternative design could be used here?
Member
There was a problem hiding this comment.
I wonder if all labels should be outside the field for consistency. We will have to do it when migrating to web awesome, right?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: