-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add dashboard time visibility condition #27790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
ef270b1 to
8fc305e
Compare
|
I guess there's no callback/event here that would cause the card to appear right at 8am, but instead it relies on the next hass update after that time to trigger the re-check? We had a similar issue with the state |
|
Not 100% sure what causes the updates but it appears to be pretty on time. There might be some efficiencies on when the conditions are refreshed in general, they currently seem to update a lot |
It's going to be refreshed on a |
|
We should add a timeout to update when we hit these triggers. This should be done via a mixin alongside other conditional listeners (media query etc.) to reuse later. Starting with moving the current listeners. Created a task for this: #27810 |
|
If you're designing a new mechanism maybe keep this one in mind, someone was trying to come up with a solution for a similar problem for |
5d325b5 to
7083b99
Compare
|
There's a lot of refactoring in this branch unrelated to the actual change, I will move these into a new branch and rebase after |
ed7a9d9 to
dceab44
Compare
Breaking change
Proposed change
Also moved some reusable logic into common areas
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: