Skip to content

Conversation

@balloob
Copy link
Member

@balloob balloob commented Jan 2, 2026

Breaking change

Proposed change

With the Bluetooth adapter being linked from the main menu, it should show information about all available bluetooth adapters at the same time. This PR makes the required updates for that by:

  • first card shows all adapters and their warnings
  • allocations are now shown alongside the adapter entry
  • Move all features into tabs
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added this to the 2026.1 milestone Jan 2, 2026
@frenck frenck requested a review from Copilot January 2, 2026 10:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts:125

  • The hardcoded string "Bluetooth" should use the localization system instead. Replace with this.hass.localize("ui.panel.config.bluetooth.title") to maintain consistency with the rest of the codebase and support internationalization.
        this._scannerDetails = details;

@silamon silamon removed this from the 2026.1 milestone Jan 3, 2026
@silamon
Copy link
Contributor

silamon commented Jan 3, 2026

I'm pushing back on features that are putted into the beta milestone. Don't take it as we don't want to have it, or we don't have interest in this cool feature you're working on during the holidays, it's just that we should respect that there's no priority queue.

@balloob
Copy link
Member Author

balloob commented Jan 5, 2026

Okay. Then lets remove the Bluetooth menu item for now as it was broken, and this PR fixes it.

MindFreeze
MindFreeze previously approved these changes Jan 5, 2026
Copy link
Member

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we merge it without the milestone?

@piitaya
Copy link
Member

piitaya commented Jan 5, 2026

I guess this should fix that issue so may be we can consider milestone? I will take a look

CleanShot.2026-01-05.at.10.11.20.mp4

@bdraco bdraco added this to the 2026.1 milestone Jan 5, 2026
@bdraco
Copy link
Member

bdraco commented Jan 5, 2026

We lost making it obvious that an adapter (likely Shelly) doesn't support making active connections which is a key confusion point for users. Without this, users might wonder why their Bluetooth devices aren't working with certain proxies
Screenshot 2026-01-05 at 12 04 56 PM

@bdraco
Copy link
Member

bdraco commented Jan 5, 2026

I think we need to keep "ui.panel.config.bluetooth.no_active_connection_support" but a shorter version for the secondary text

@bdraco
Copy link
Member

bdraco commented Jan 5, 2026

I re-added the milestone since this solves the above issue with the Bluetooth menu item. Maybe we drop the last commit because of the feature creep but it feels like nitpick territory so I'm fine with it either way.

@piitaya
Copy link
Member

piitaya commented Jan 6, 2026

CleanShot 2026-01-06 at 09 58 34

@bdraco I removed the last commit and added "no connection slots" when needed.

@piitaya piitaya requested a review from MindFreeze January 6, 2026 13:24
@MindFreeze MindFreeze merged commit 6793edd into dev Jan 6, 2026
14 checks passed
@MindFreeze MindFreeze deleted the bluetooth-panel-multi-adapter branch January 6, 2026 14:46
bramkragten pushed a commit that referenced this pull request Jan 6, 2026
* Support multiple adapters in bluetooth panel

* Move connection allocations up

* Make it tabs

* Add icons

* Revert "Add icons"

This reverts commit e338b6e.

* Revert "Make it tabs"

This reverts commit d1b19d5.

* Fix scanner matching and no active connection slot support

* Update src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts

---------

Co-authored-by: Paul Bottein <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: Petar Petrov <[email protected]>
@piitaya piitaya mentioned this pull request Jan 6, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants