-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Bluetooth panel to support multi adapter #28763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts:125
- The hardcoded string "Bluetooth" should use the localization system instead. Replace with this.hass.localize("ui.panel.config.bluetooth.title") to maintain consistency with the rest of the codebase and support internationalization.
this._scannerDetails = details;
src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts
Show resolved
Hide resolved
src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts
Show resolved
Hide resolved
|
I'm pushing back on features that are putted into the beta milestone. Don't take it as we don't want to have it, or we don't have interest in this cool feature you're working on during the holidays, it's just that we should respect that there's no priority queue. |
|
Okay. Then lets remove the Bluetooth menu item for now as it was broken, and this PR fixes it. |
MindFreeze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we merge it without the milestone?
|
I guess this should fix that issue so may be we can consider milestone? I will take a look CleanShot.2026-01-05.at.10.11.20.mp4 |
|
I think we need to keep "ui.panel.config.bluetooth.no_active_connection_support" but a shorter version for the secondary text |
|
I re-added the milestone since this solves the above issue with the Bluetooth menu item. Maybe we drop the last commit because of the feature creep but it feels like nitpick territory so I'm fine with it either way. |
@bdraco I removed the last commit and added "no connection slots" when needed. |
src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts
Outdated
Show resolved
Hide resolved
…uetooth-config-dashboard.ts
* Support multiple adapters in bluetooth panel * Move connection allocations up * Make it tabs * Add icons * Revert "Add icons" This reverts commit e338b6e. * Revert "Make it tabs" This reverts commit d1b19d5. * Fix scanner matching and no active connection slot support * Update src/panels/config/integrations/integration-panels/bluetooth/bluetooth-config-dashboard.ts --------- Co-authored-by: Paul Bottein <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Petar Petrov <[email protected]>


Breaking change
Proposed change
With the Bluetooth adapter being linked from the main menu, it should show information about all available bluetooth adapters at the same time. This PR makes the required updates for that by:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: