Skip to content

Conversation

@KapJI
Copy link
Member

@KapJI KapJI commented Feb 16, 2020

Proposed change

When item text is wrapped, flex container in paper-icon-item shrinks icon div which causes misaligned text. Set max width for the item text to prevent this. 56px is the default width of icon spacer div (here) in paper-icon-item.

Better fix is PolymerElements/paper-item#133 but that project doesn't seem to be active and it's unlikely that fix will be reviewed soon.

Before:
Screen Shot 2020-02-16 at 6 20 34 PM

After:
Screen Shot 2020-02-16 at 6 24 43 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Member

balloob commented Feb 17, 2020

Thanks! Developer tools is 3 words in your language ?

@balloob balloob merged commit 24e4b0b into home-assistant:dev Feb 17, 2020
@KapJI
Copy link
Member Author

KapJI commented Feb 17, 2020

@balloob it says "tools for developers"

@bramkragten bramkragten mentioned this pull request Feb 17, 2020
@lock lock bot locked and limited conversation to collaborators Feb 18, 2020
@KapJI KapJI deleted the ukr-button-fix branch March 29, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants