Skip to content

Remove trailing slash from manual inputed server URL in onboarding #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgoncal merged 2 commits into from
Feb 13, 2025
Merged

Remove trailing slash from manual inputed server URL in onboarding #3430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f20913
Remove trailing slash from manual inputed server URL in onboarding
bgoncal Feb 13, 2025
d54239a
Merge branch 'master' into remove-last-slash-onboarding-url
bgoncal Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Sources/App/Onboarding/Screens/OnboardingManualURLViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ class OnboardingManualURLViewController: UIViewController, UITextFieldDelegate {

isConnecting = true

if let urlString = urlField.text {
urlField.text = removeTrailingSlash(from: urlString)
}

let authentication = OnboardingAuth()

firstly {
Expand Down Expand Up @@ -215,6 +219,14 @@ class OnboardingManualURLViewController: UIViewController, UITextFieldDelegate {
}
}

private func removeTrailingSlash(from string: String) -> String {
if string.hasSuffix("/") {
return String(string.dropLast())
} else {
return string
}
}

private func promptForScheme(for string: String) -> Promise<String> {
Promise { seal in
let alert = UIAlertController(
Expand Down
Loading