Improve onboarding servers searching screen#3688
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements a new UI for the server‐searching screen with a loader animation and paves the way for auto‐connecting to the first discovered instance.
- Replaces the old scanning animation with
SearchingServersAnimationViewand inserts loader logic inOnboardingServersListView - Refactors the servers list from a
Listto aScrollView, adds center and inline loaders, and schedules auto‐connect - Extends the design system with new 8-point
Spaces,CornerRadius, and deprecates the oldCornerRadiusSizes
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/Resources/Swiftgen/Strings.swift | Added onboarding.servers.title and a new header key for the welcome step |
| Sources/Shared/DesignSystem/DesignSystem.swift | Introduced 8-point Spaces, CornerRadius, and Border enums |
| Sources/Shared/DesignSystem/Constants/CornerRadiusSizes.swift | Deprecated the old CornerRadiusSizes enum |
| Sources/App/Resources/en.lproj/Localizable.strings | Added a new string key for server‐searching title |
| Sources/App/Resources/Assets.xcassets/searching-servers-dots.imageset/Contents.json | Added new loader dots asset |
| Sources/App/Resources/Assets.xcassets/logo-in-circle.imageset/Contents.json | Added new logo‐in‐circle asset |
| Sources/App/Onboarding/Views/SearchingServersAnimationView.swift | New SwiftUI view for rotating dots and pulsing logo |
| Sources/App/Onboarding/Steps/Welcome/OnboardingWelcomeView.swift | Wrapped content in a ScrollView and adjusted button background |
| Sources/App/Onboarding/Steps/Servers/OnboardingServersListView.swift | Switched from List to ScrollView, added center/inline loaders, auto‐connect scheduling, and toolbar refactor |
| Sources/App/Onboarding/Steps/Servers/OnboardingServersListViewModel.swift | Added showCenterLoader state |
| Sources/App/Onboarding/Steps/Servers/OnboardingScanningInstanceRow.swift | Refactored row UI with consistent spacing, icon container, and border overlay |
| HomeAssistant.xcodeproj/project.pbxproj | Removed old ServersScanAnimationView references and added SearchingServersAnimationView entries |
Comments suppressed due to low confidence (1)
Sources/App/Onboarding/Views/SearchingServersAnimationView.swift
Outdated
Show resolved
Hide resolved
Sources/App/Resources/Assets.xcassets/searching-servers-dots.imageset/Contents.json
Show resolved
Hide resolved
1 build increased size
Home Assistant 2025.6.1 (2025.5172)
|
| Item | Install Size Change |
|---|---|
| 📝 Image.png | ⬆️ 0 B |
| 📝 Image.png | ⬆️ 0 B |
| Shared | ⬆️ 16.4 kB |
| HomeAssistant.OnboardingServersListView.body | ⬇️ -6.6 kB |
| 📝 HomeAssistant.OnboardingServersListView.content | ⬆️ 4.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
+ Coverage 44.72% 45.68% +0.96%
==========================================
Files 232 232
Lines 13911 14059 +148
==========================================
+ Hits 6221 6423 +202
+ Misses 7690 7636 -54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-01.at.15.53.55.mp4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes