Auto connect to server while onboarding if no other server is detected#3694
Merged
Auto connect to server while onboarding if no other server is detected#3694
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the onboarding flow by automatically prompting the user to connect when exactly one server is discovered, using an updated bottom sheet component.
- Adds a localized “Connect” button string for auto-connect
- Extends
AppleLikeBottomSheetto support a title and custom dismiss logic - Implements scheduling and UI for auto-connect in
OnboardingServersListView
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/Resources/Swiftgen/Strings.swift | Added AutoConnect enum with localized button key |
| Sources/Shared/DesignSystem/Components/AppleLikeBottomSheet.swift | Extended bottom sheet with title, custom dismiss, and styling refactors |
| Sources/App/Resources/en.lproj/Localizable.strings | Added new localization entry for onboarding.servers.auto_connect.button |
| Sources/App/Onboarding/Steps/Servers/OnboardingServersListViewModel.swift | Handled cancelled authentication flow before showing errors |
| Sources/App/Onboarding/Steps/Servers/OnboardingServersListView.swift | Introduced auto-connect scheduling, bottom sheet view, and related UI constants |
Comments suppressed due to low confidence (2)
Sources/Shared/DesignSystem/Components/AppleLikeBottomSheet.swift:9
- [nitpick] Property name
closebuttonSizeshould follow Swift camelCase conventions; rename tocloseButtonSizefor clarity.
static let closebuttonSize: CGFloat = 30
Sources/App/Onboarding/Steps/Servers/OnboardingServersListView.swift:100
- The new auto-connect flow and bottom sheet UI are core onboarding behaviors but currently lack dedicated tests. Please add unit or UI tests to cover scheduling, cancellation, and user interactions with the auto-connect sheet.
@ViewBuilder
Sources/App/Onboarding/Steps/Servers/OnboardingServersListView.swift
Outdated
Show resolved
Hide resolved
….swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3694 +/- ##
==========================================
+ Coverage 44.72% 45.54% +0.82%
==========================================
Files 232 233 +1
Lines 13911 14101 +190
==========================================
+ Hits 6221 6423 +202
+ Misses 7690 7678 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-03.at.17.31.27.mp4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes