Refactor AppDatabaseUpdater for per-server updates #4224
Merged
Conversation
Reworks AppDatabaseUpdater to support bounded parallel per-server updates, global and per-server throttling with exponential backoff, and improved cancellation handling. Adds detailed documentation, separates update logic into smaller methods, and ensures batched database writes with differential deletes. This improves update reliability, resource usage, and responsiveness to cancellation.
AppDatabaseUpdater now supports concurrent updates per server instead of a single global update. The update method requires a server parameter, and task management is handled via an actor for thread safety. Call sites in SettingsView and WebViewController are updated to use the new API, and legacy global update logic is removed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors AppDatabaseUpdater to support per-server updates instead of updating all servers at once. The updater now ensures only one update per server runs at a time (while allowing different servers to update concurrently), implements per-server throttling with exponential backoff on failures, and improves cancellation handling throughout the update pipeline.
Changes:
- Introduced a
TaskCoordinatoractor for thread-safe management of per-server update tasks - Implemented per-server throttling (120s base) with exponential backoff (up to 5 minutes) on consecutive failures
- Enhanced cancellation checks at critical points in the update pipeline to enable early exit
- Updated API from
update()toupdate(server: Server)and modified all call sites accordingly
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| Sources/Shared/Environment/AppDatabaseUpdater.swift | Core refactor: added TaskCoordinator actor, per-server task tracking, throttling/backoff logic, and improved cancellation handling throughout |
| Sources/App/WebView/WebViewController.swift | Updated to call update(server:) for the specific server when connection info changes |
| Sources/App/Settings/Settings/SettingsView.swift | Changed to loop through all servers and call update(server:) for each one |
| Sources/App/Scenes/WebViewSceneDelegate.swift | Removed blanket database update call when scene becomes active (now happens per-server on connection change) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Wrap all withCheckedContinuation and withCheckedThrowingContinuation usages with [weak self] to prevent retain cycles and ensure continuations are resumed or cancelled if self is deallocated. This improves memory safety and prevents potential leaks or crashes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4224 +/- ##
=======================================
Coverage ? 44.32%
=======================================
Files ? 252
Lines ? 14580
Branches ? 0
=======================================
Hits ? 6462
Misses ? 8118
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes