Conversation
There was a problem hiding this comment.
Pull request overview
Adds a missing Siri intent localization string (mrwamX) across many supported languages to address App Store validation error ITMS-90626: Invalid Siri Support.
Changes:
- Add the new
Intents.stringskeymrwamX(“Assist In App” / localized equivalent) for multiple locales. - Provide Traditional/Simplified Chinese translations for the new key.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/App/Resources/bg.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/ca-ES.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/cs.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/cy-GB.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/da.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/de.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/el.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/en.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/es-ES.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/es-MX.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/es.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/et.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/fi.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/fr.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/he.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/hu.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/id.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/it.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/ja.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/ko-KR.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/ml.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/nb.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/nl.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/pl-PL.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/pt-BR.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/ru.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/sl.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/sv.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/tr.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/uk.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/vi.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/zh-Hans.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| Sources/App/Resources/zh-Hant.lproj/Intents.strings | Add mrwamX localized string for Siri intent combination title |
| "lxHlyQ" = "Fire Event"; | ||
| "mAibJP" = "Failed: Home Assistant is not currently reachable"; | ||
| "mJ6CrP" = "Failed to send ${eventName}: ${error}"; | ||
| "mrwamX" = "Assist In App"; |
There was a problem hiding this comment.
Intents.intentdefinition references the new localization key mrwamX (managed parameter combination title), but en-GB.lproj/Intents.strings does not currently define mrwamX. This will likely keep triggering ITMS-90626 / missing Siri intent localization for en-GB. Add the mrwamX entry to Sources/App/Resources/en-GB.lproj/Intents.strings (same value as en, or an en-GB specific translation).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
=======================================
Coverage ? 43.42%
=======================================
Files ? 260
Lines ? 14991
Branches ? 0
=======================================
Hits ? 6510
Misses ? 8481
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes