Skip to content

Add live_update and critical_text to notification keys#269

Merged
jpelgrom merged 1 commit intomainfrom
dshokouhi-patch-8
Feb 24, 2026
Merged

Add live_update and critical_text to notification keys#269
jpelgrom merged 1 commit intomainfrom
dshokouhi-patch-8

Conversation

@dshokouhi
Copy link
Member

Copilot AI review requested due to automatic review settings February 24, 2026 20:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for two new Android notification keys (live_update and critical_text) to the FCM push notification server for Home Assistant mobile apps. These keys correspond to new notification features being added in the Android app (as referenced in the linked PR).

Changes:

  • Added live_update and critical_text to the androidNotificationKeys array in functions/android.js

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jpelgrom
Copy link
Member

It's been a while since we added something, too easy to forget. Thanks!

@dshokouhi
Copy link
Member Author

going ot try closing and reopening to see if codecov will restart

@dshokouhi dshokouhi closed this Feb 24, 2026
@dshokouhi dshokouhi reopened this Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.52%. Comparing base (6b177fc) to head (1df2471).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files          10       10           
  Lines         625      625           
  Branches      177      177           
=======================================
  Hits          422      422           
  Misses        158      158           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpelgrom jpelgrom merged commit bc6e42c into main Feb 24, 2026
9 checks passed
@jpelgrom jpelgrom deleted the dshokouhi-patch-8 branch February 24, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants