Skip to content

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jul 22, 2025

Proposed change

Add information about NVMe lifetime to API for use in frontend when system is using an NVME device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

@mdegat01 mdegat01 requested review from agners and sairon July 22, 2025 19:58
@mdegat01 mdegat01 added the new-feature A new feature label Jul 22, 2025
@mdegat01 mdegat01 added missing-documentation Added to pull requests that needs a docs, but none is linked needs-cli Pull requests needs CLI changes but none is linked needs-client-library Pull requests needs client library changes but none is linked labels Jul 22, 2025
@mdegat01 mdegat01 removed the needs-cli Pull requests needs CLI changes but none is linked label Jul 23, 2025
@mdegat01 mdegat01 removed the needs-client-library Pull requests needs client library changes but none is linked label Jul 23, 2025
@mdegat01 mdegat01 removed the missing-documentation Added to pull requests that needs a docs, but none is linked label Jul 23, 2025
@agners agners changed the title Add NVME lifetime info to API Add NVMe lifetime info to API Jul 28, 2025
web.post("/host/options", api_host.options),
web.get("/host/services", api_host.services),
web.get("/host/nvme/{device}/status", api_host.nvme_device_status),
web.get("/host/nvme/status", api_host.nvme_device_status),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this goes a bit further then what we've intended.

The main aim should be to return a device health similar to what we have with eMMC, essentially make this work for NVMe's:

# Currently only eMMC block devices supported
return self._try_get_emmc_life_time(mount_source_device_name)

@agners agners marked this pull request as draft July 29, 2025 14:16
@mdegat01 mdegat01 mentioned this pull request Jul 31, 2025
14 tasks
@mdegat01
Copy link
Contributor Author

Change approach, this is no longer needed. Replaced by #6056

@mdegat01 mdegat01 closed this Jul 31, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants